NO-JIRA: fix: resolve some integration tests#750
NO-JIRA: fix: resolve some integration tests#750openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
Conversation
|
@eggfoobar: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bumped library go to pull in fixes for integration tests Signed-off-by: ehila <ehila@redhat.com>
26d9033 to
db50de8
Compare
|
/unhold Library-go has been updated, this PR will only resolve issue 1 and 2, integration tests will still fail but now we only fail on cert mismatch |
updated controller initializations to pass down clock param for testing updated tests results to be in lexical order and timestamp to reflect test.yaml Signed-off-by: ehila <ehila@redhat.com>
db50de8 to
b906a10
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, eggfoobar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
a9ec252
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-authentication-operator |
There are three issues that are currently the reason for the integration tests failing
This PR pulls in the a latest from library-go and resolves number 1 and number 2.
/hold
We'll need to wait for openshift/library-go#1916 to be merged in.